Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues related to the mail test by updating the test suite initialization and enhancing configuration mocks for queue connections.
- Adds a call to suite.Run for ApplicationTestSuite in TestApplicationTestSuite.
- Updates the redis queue configuration expectations in TestQueueMailWithConnection.
- Introduces a new expectation for the async queue size in the mock configuration.
Comments suppressed due to low confidence (2)
mail/application_test.go:109
- Confirm that the expectation of calling the redis queue configuration method twice is intentional. If the method is only invoked once in production, consider revising to Once().
s.mockConfig.On("GetString", "queue.connections.redis.queue", "default").Return("default").Twice()
mail/application_test.go:171
- [nitpick] Double-check that this expectation for the async queue size is necessary and not redundant with similar configuration mocks elsewhere. If consolidation is possible, please adjust for consistency.
mockConfig.On("GetInt", "queue.connections.async.size", 100).Return(100)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
=======================================
Coverage 69.31% 69.31%
=======================================
Files 160 160
Lines 10713 10713
=======================================
Hits 7426 7426
Misses 2951 2951
Partials 336 336 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
✅ Checks