Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds benchmark tests to evaluate database operations and improves logger variable consistency while updating model struct annotations. Key changes include:
- Addition of Benchmark_Orm benchmark in tests/query_test.go.
- Addition of Benchmark_DB benchmark in tests/db_test.go.
- Consolidation of trace string variables in database/logger/logger.go.
- Update of the Author struct in tests/models.go with a db tag.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/query_test.go | Introduced Benchmark_Orm for benchmarking DB operations. |
| tests/db_test.go | Introduced Benchmark_DB for benchmarking DB operations. |
| database/logger/logger.go | Moved trace variable declarations to package scope. |
| tests/models.go | Added db:"name" annotation in Author struct. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
=======================================
Coverage 69.31% 69.31%
=======================================
Files 160 160
Lines 10713 10713
=======================================
Hits 7426 7426
Misses 2951 2951
Partials 336 336 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
✅ Checks