Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #954 +/- ##
==========================================
- Coverage 69.14% 69.14% -0.01%
==========================================
Files 158 158
Lines 10602 10607 +5
==========================================
+ Hits 7331 7334 +3
- Misses 2940 2942 +2
Partials 331 331 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6c0693a to
2419868
Compare
ab77aeb to
8f6a51f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces optimizations for database read/write operations and refactors several components including the ORM, query builder, and connection handling while removing deprecated fields and test files.
- Refactors Gorm and DB building methods for streamlined initialization.
- Updates query generation to use distinct read and write builders.
- Removes version-related fields and corresponding test files to optimize and simplify configuration.
Reviewed Changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| database/driver/gorm.go | Refactored Gorm configuration and connection handling. |
| database/db/builder.go | Introduced Builder and TxBuilder for database operations. |
| database/schema/schema.go | Updated schema initialization to return errors and handle connections. |
| database/console/show_command.go | Removed version output and updated display logic. |
| contracts/database/config.go | Removed deprecated fields and added new configuration options. |
| database/db/to_sql.go | Updated SQL generation to use builder’s Explain method. |
| database/db/db.go | Refactored DB/transaction building to use Gorm and unified builders. |
| database/gorm/query.go | Adjusted query construction to utilize updated driver pool settings. |
| contracts/database/driver/* | Updated grammar and driver interfaces to support common grammar. |
| database/db/query.go | Significantly refactored query methods to use read/write builders. |
| database/service_provider.go | Updated service registration to reflect changes in DB and schema. |
| contracts/database/db/db.go | Extended CommonBuilder interface with an Explain method. |
| database/orm/orm.go | Minor cleanup by removing the database version getter. |
Comments suppressed due to low confidence (1)
database/db/db_test.go:1
- The removal of the db_test.go file could reduce test coverage for core database functionalities; ensure that equivalent tests are implemented elsewhere to maintain coverage.
Entire file removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
See: #954 (review)
✅ Checks