feat: [#358] Update tests, completed finally#952
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR updates the database testing suite and dependency versions for improved testing and compatibility.
- Moves the loop over s.queries inside the Test_DB_Select_Update_Delete function for proper ordering
- Updates dependency versions in tests/go.mod for database drivers
Reviewed Changes
| File | Description |
|---|---|
| tests/db_test.go | Moved the loop iterating over s.queries to ensure proper execution order |
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #952 +/- ##
=======================================
Coverage 69.15% 69.15%
=======================================
Files 157 157
Lines 10526 10526
=======================================
Hits 7279 7279
Misses 2913 2913
Partials 334 334 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
almas-x
pushed a commit
that referenced
this pull request
Mar 12, 2025
almas-x
pushed a commit
that referenced
this pull request
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#358
This pull request includes updates to the
tests/db_test.gofile and thetests/go.modfile to improve the database testing suite and update dependencies.Improvements to database testing suite:
tests/db_test.go: Moved the loop iterating overs.queriesinside theTest_DB_Select_Update_Deletefunction to ensure the correct order of operations for different database drivers.Dependency updates:
tests/go.mod: Updated the versions of database driver dependencies (mysql,postgres,sqlite,sqlserver) to their latest versions to ensure compatibility and leverage any improvements or bug fixes.✅ Checks