Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #931 +/- ##
=======================================
Coverage 68.82% 68.82%
=======================================
Files 154 154
Lines 10200 10200
=======================================
Hits 7020 7020
Misses 2857 2857
Partials 323 323 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 50f17a6 | Previous: c3e937f | Ratio |
|---|---|---|---|
BenchmarkFile_ReadWrite |
296340 ns/op 2072 B/op 28 allocs/op |
188515 ns/op 2072 B/op 28 allocs/op |
1.57 |
BenchmarkFile_ReadWrite - ns/op |
296340 ns/op |
188515 ns/op |
1.57 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
PR Overview
This PR introduces new query methods—including Count, Pluck, DoesntExist, FirstOr, Decrement, Increment, InsertGetId, When, and Latest—to enhance the database query builder functionality and adds corresponding tests for these methods.
- New query methods in database/db/query.go with updated condition field naming.
- Updated test files (database/db/query_test.go and tests/db_test.go) to cover the added methods.
- Adjustments to the mock builder and interface contracts to support the new functionality.
Reviewed Changes
| File | Description |
|---|---|
| database/db/query_test.go | Added tests for Count, Decrement, Distinct, FirstOr, Increment, InsertGetId, Latest, When, and Pluck. |
| tests/db_test.go | Extended tests for query methods including Count, Decrement, Distinct, Increment, InsertGetId, and Pluck. |
| mocks/database/db/Builder.go | Added Query method mocks to support new builder functionality. |
| database/db/query.go | Introduced new query methods and updated condition field references to uppercase. |
| contracts/database/db/db.go | Updated the Query interface with new methods and detailed comments. |
| database/db/conditions.go | Updated Conditions struct field names from lowercase to uppercase. |
| database/db/utils.go | Modified error returns in the conversion functions to use a standardized error message. |
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
database/db/query.go:68
- [nitpick] In the Count() method, the trace() call uses -1 for rowsAffected even on success; consider using a more representative value (e.g., the actual count) or a consistent placeholder to improve logging clarity.
r.trace(sql, args, -1, nil)
almas-x
pushed a commit
that referenced
this pull request
Mar 12, 2025
…ent, Increment, InsertGetId, When methods (#931) * feat: [#358] Add Value method * chore: update mocks * Add Limit method * update mock * fix sqlserver limit * chore: update mocks * remove unnecessary code * add Count method * chore: update mocks * add FirstOr method * add FirstOr method * add DoesntExist method * add InsertGetId method * add Latest method * add Latest method * add Distinct method * update mock * update mock * cancel test * optimize Pluck --------- Co-authored-by: hwbrzzl <24771476+hwbrzzl@users.noreply.github.com>
almas-x
pushed a commit
that referenced
this pull request
Mar 18, 2025
…ent, Increment, InsertGetId, When methods (#931) * feat: [#358] Add Value method * chore: update mocks * Add Limit method * update mock * fix sqlserver limit * chore: update mocks * remove unnecessary code * add Count method * chore: update mocks * add FirstOr method * add FirstOr method * add DoesntExist method * add InsertGetId method * add Latest method * add Latest method * add Distinct method * update mock * update mock * cancel test * optimize Pluck --------- Co-authored-by: hwbrzzl <24771476+hwbrzzl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
goravel/goravel#358
@coderabbitai summary
✅ Checks