feat: [#358] Implement Exists, Find, FirstOrFail, Select methods#928
Merged
feat: [#358] Implement Exists, Find, FirstOrFail, Select methods#928
Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 6f6d525 | Previous: 84fded1 | Ratio |
|---|---|---|---|
BenchmarkFile_ReadWrite |
297096 ns/op 2072 B/op 28 allocs/op |
184761 ns/op 2072 B/op 28 allocs/op |
1.61 |
BenchmarkFile_ReadWrite - ns/op |
297096 ns/op |
184761 ns/op |
1.61 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #928 +/- ##
=======================================
Coverage 68.82% 68.82%
=======================================
Files 154 154
Lines 10200 10200
=======================================
Hits 7020 7020
Misses 2857 2857
Partials 323 323 ☔ View full report in Codecov by Sentry. |
almas-x
pushed a commit
that referenced
this pull request
Mar 12, 2025
* feat: [#358] Implement Find method * chore: update mocks * add Select method * add Exists method * update mock * implement FirstOrFail * update between --------- Co-authored-by: hwbrzzl <24771476+hwbrzzl@users.noreply.github.com>
almas-x
pushed a commit
that referenced
this pull request
Mar 18, 2025
* feat: [#358] Implement Find method * chore: update mocks * add Select method * add Exists method * update mock * implement FirstOrFail * update between --------- Co-authored-by: hwbrzzl <24771476+hwbrzzl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
goravel/goravel#358
@coderabbitai summary
✅ Checks