Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR implements the OrderBy functionality to support sorting in queries as described in issue [#358].
- Added three new methods (OrderBy, OrderByDesc, OrderByRaw) in the Query struct.
- Updated buildSelect in query.go to include orderBy clauses.
- Added a new orderBy field in the Conditions struct and updated the corresponding interface in contracts.
Reviewed Changes
| File | Description |
|---|---|
| database/db/query_test.go | Added tests for OrderBy, OrderByDesc, and OrderByRaw usage. |
| database/db/query.go | Implemented new OrderBy methods and modified buildSelect to apply ordering. |
| database/db/conditions.go | Added orderBy field in Conditions to store ordering clauses. |
| contracts/database/db/db.go | Updated Query interface with OrderBy methods. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
database/db/query.go:178
- The clone() method performs a shallow copy of conditions, including the mutable orderBy slice. Consider deep copying conditions.orderBy to avoid unintended side effects when appending new order clauses.
query.conditions = r.conditions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #927 +/- ##
=======================================
Coverage 68.82% 68.82%
=======================================
Files 154 154
Lines 10200 10200
=======================================
Hits 7020 7020
Misses 2857 2857
Partials 323 323 ☔ View full report in Codecov by Sentry. |
almas-x
pushed a commit
that referenced
this pull request
Mar 12, 2025
almas-x
pushed a commit
that referenced
this pull request
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
goravel/goravel#358
@coderabbitai summary
✅ Checks