fix: Problem with submodels id string by dzham · Pull Request #898 · goravel/framework

dzham · 2025-02-19T05:28:18Z

📑 Description

I found an error while working with the model.
link problem with the GetIDByReflect method. This method does not properly handle submodel with id string.
Also, this method does not process variants with double nesting.

The problem is here, not in nested fields it works correctly

cast.ToString(id) == "" || cast.ToInt(id) == 0

The problem with such models

type User struct {
   TestStructString
   Name string
}

ts := User{Name: "name"}
ts.ID = "testId"

And with nested models

type UserFirst struct {
	TestStructString
	Name string
}
type UserSecond struct {
	UserFirst
	Avatar string
}

ts := UserSecond{}
ts.ID = "testId"

And I also refactored this method a little

coderabbitai · 2025-02-19T05:28:27Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-02-19T05:30:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (2cdb138) to head (c153667).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #898   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files         152      152           
  Lines       10050    10050           
=======================================
  Hits         6799     6799           
  Misses       2925     2925           
  Partials      326      326

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

support/database/database.go

hwbrzzl

Thanks, good catch!

hwbrzzl

Sorry, CI failed, I'm checking it.

dzham · 2025-02-19T12:33:21Z

support/database/database.go

I didn't want to break the current logic. Added changes.

hwbrzzl · 2025-02-19T13:49:03Z

support/database/database.go

-	"github.com/spf13/cast"
 )

 func GetID(dest any) any {


Please remove line 16~18

hwbrzzl

Great 👍

hwbrzzl · 2025-02-20T09:06:49Z

Hey @dzham Added you to the contributor list, and if you use Discord, you can send a message to me, I'll add you the contributor role.

Fix submodel id string bug

425140e

dzham requested a review from a team as a code owner February 19, 2025 05:28

dzham changed the title ~~Fix submodel id string bug~~ Problem with models with id string Feb 19, 2025

dzham changed the base branch from master to v1.15.x February 19, 2025 05:31

dzham changed the base branch from v1.15.x to master February 19, 2025 05:32

dzham commented Feb 19, 2025

View reviewed changes

support/database/database.go Show resolved Hide resolved

fix id test

2f888f9

hwbrzzl approved these changes Feb 19, 2025

View reviewed changes

hwbrzzl requested changes Feb 19, 2025

View reviewed changes

dzham changed the title ~~Problem with models with id string~~ fix: Problem with submodels id string Feb 19, 2025

hwbrzzl reviewed Feb 19, 2025

View reviewed changes

dzham added 2 commits February 19, 2025 15:25

add check field anonymous

24d08e1

add check field pointer

acf5822

hwbrzzl reviewed Feb 19, 2025

View reviewed changes

support/database/database.go

"github.com/spf13/cast"

)

func GetID(dest any) any {

Copy link

Contributor

hwbrzzl Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove line 16~18

remocve old check pointer

c153667

hwbrzzl approved these changes Feb 20, 2025

View reviewed changes

hwbrzzl merged commit fb74e24 into goravel:master Feb 20, 2025
14 checks passed

Conversation

dzham commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Uh oh!

coderabbitai bot commented Feb 19, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

dzham Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hwbrzzl commented Feb 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dzham commented Feb 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Feb 19, 2025 •

edited

Loading