feat: [#540] Remove database.connections.* by hwbrzzl · Pull Request #827 · goravel/framework

hwbrzzl · 2025-01-22T10:20:21Z

📑 Description

Framework should not know database.connections.*, it is decided by the sub-DB packages.

Summary by CodeRabbit

Testing
- Updated test configurations for database and migration settings
- Simplified database connection configuration tests
- Removed specific port configuration checks in test suite
Refactor
- Modified configuration structure for database migrations
- Removed unnecessary configuration port settings

Note: These changes appear to be internal testing and configuration adjustments with minimal end-user impact.

✅ Checks

Added test cases for my code

coderabbitai · 2025-01-22T10:20:28Z

Walkthrough

The pull request introduces changes to configuration handling in the testing infrastructure, specifically modifying how database configurations are managed. The changes involve removing specific database connection port configurations and adjusting the structure of migration-related settings. The modifications impact test configurations in config/application_test.go, testing/docker/database.go, and testing/docker/database_test.go, focusing on simplifying and restructuring database-related test setups.

Changes

File	Change Summary
`config/application_test.go`	Removed MySQL connection `host` configuration, added `migrations.table` configuration
`testing/docker/database.go`	Removed database connection port configuration logic
`testing/docker/database_test.go`	Removed `contractstesting` import and database port configuration test expectations

Sequence Diagram

sequenceDiagram
    participant Config as Configuration
    participant Test as Test Suite
    participant Database as Database Setup

    Config->>Test: Define migration table configuration
    Test->>Database: Initialize database connection
    Database-->>Test: Verify configuration settings

Possibly related PRs

chore: optimize testing.Docker.Database #656: Updates to database configuration handling in testing infrastructure
feat: [#272] The Orm module can set DSN directly #763: Introduction of new Dsn field in configuration struct

Suggested reviewers

devhaozi
kkumar-gcc

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c28d76f and 5a00358.

📒 Files selected for processing (3)

config/application_test.go (1 hunks)
testing/docker/database.go (0 hunks)
testing/docker/database_test.go (0 hunks)

💤 Files with no reviewable changes (2)

testing/docker/database.go
testing/docker/database_test.go

⏰ Context from checks skipped due to timeout of 300000ms (2)

GitHub Check: test / windows (1.23)
GitHub Check: test / windows (1.22)

🔇 Additional comments (2)

config/application_test.go (2)

110-111: LGTM! Configuration structure aligns with PR objectives.

The migration table configuration is appropriately placed at the framework level, following the goal of removing database connection specifics.

116-117: LGTM! Test coverage is comprehensive.

The test cases properly verify the new configuration structure for both config instances, ensuring consistent behavior.

Let's verify that all database connection configuration has been removed:

Also applies to: 122-122, 125-125

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hwbrzzl · 2025-01-22T10:21:05Z

testing/docker/database.go

 		return err
 	}

-	r.config.Add(fmt.Sprintf("database.connections.%s.port", r.connection), r.DatabaseDriver.Config().Port)


The port will be updated by the sub-DB packages.

codecov · 2025-01-22T10:23:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.05%. Comparing base (c28d76f) to head (5a00358).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   67.06%   67.05%   -0.01%     
==========================================
  Files         147      147              
  Lines       10396    10394       -2     
==========================================
- Hits         6972     6970       -2     
  Misses       3051     3051              
  Partials      373      373

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

feat: [#540] Remove database.connections.*

5a00358

hwbrzzl requested a review from a team as a code owner January 22, 2025 10:20

hwbrzzl commented Jan 22, 2025

View reviewed changes

hwbrzzl added the 🚀 Review Ready label Jan 22, 2025

hwbrzzl merged commit 85749fc into master Jan 22, 2025
11 of 13 checks passed

hwbrzzl deleted the bowen/#540-3 branch January 22, 2025 13:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [#540] Remove database.connections.*#827

feat: [#540] Remove database.connections.*#827
hwbrzzl merged 1 commit intomasterfrom
bowen/#540-3

hwbrzzl commented Jan 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 22, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

hwbrzzl Jan 22, 2025

Uh oh!

codecov bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

hwbrzzl commented Jan 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Summary by CodeRabbit

✅ Checks

Uh oh!

coderabbitai bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

hwbrzzl Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

hwbrzzl commented Jan 22, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jan 22, 2025 •

edited

Loading