Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the HTTP request abstraction by introducing an OriginPath method to provide both the original and current request paths.
- Introduces OriginPath() in the ContextRequest interface with its corresponding documentation.
- Adds a new mock implementation for OriginPath, including helper functions for testing expectations.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| contracts/http/request.go | Adds OriginPath() method to the interface with updated comments |
| mocks/http/ContextRequest.go | Implements OriginPath() in the mock along with helper methods |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1062 +/- ##
=======================================
Coverage 71.31% 71.31%
=======================================
Files 181 181
Lines 12732 12732
=======================================
Hits 9080 9080
Misses 3263 3263
Partials 389 389 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#510
This pull request introduces enhancements to the
ContextRequestinterface and its associated mock implementation. The changes focus on adding support for retrieving the original path of an HTTP request, improving functionality and testing capabilities.Enhancements to the
ContextRequestinterface:OriginPath()to retrieve the original path of the request (e.g.,/users/{id}), alongside the existingPath()method for the current path (e.g.,/users/1). (contracts/http/request.go, contracts/http/request.goL21-R23)Updates to the mock implementation:
OriginPath()method in the mockContextRequestclass, including helper methods (Run,Return, andRunAndReturn) for defining mock behavior and expectations. (mocks/http/ContextRequest.go, mocks/http/ContextRequest.goR1305-R1336)✅ Checks