Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 71.23% 71.28% +0.04%
==========================================
Files 180 181 +1
Lines 12705 12723 +18
==========================================
+ Hits 9051 9070 +19
Misses 3264 3264
+ Partials 390 389 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new queue failer feature to handle failed jobs, allowing the system to retrieve and retry them. Key changes include:
- Introducing the Failer implementation in queue/failer.go.
- Modifying test files and mocks to remove redundant empty slice initializations.
- Updating the Queue interface and related methods to incorporate the new Failer functionality.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| queue/worker_test.go | Removed unnecessary empty slice initializations from tests. |
| queue/utils/convert_test.go | Removed unused empty Chain fields in tests. |
| queue/utils/convert.go | Changed slice building approach by using append instead of preassign. |
| queue/failer.go | Added new Failer struct and methods for managing failed jobs. |
| queue/driver_database_test.go | Cleaned up test code by removing redundant empty slice initializers. |
| queue/console/queue_retry_command.go | Updated job retry logic to use Failer and simplified flow. |
| queue/application.go | Added Failer() method and reordered JobStorer() for clarity. |
| mocks/queue/Queue.go | Updated mocks to remove now-obsolete GetJobStorer methods. |
| mocks/queue/Failer.go | New mock implementations for the Failer interface. |
| mocks/queue/FailedJob.go | New mock implementations for the FailedJob interface. |
| contracts/queue/queue.go | Modified queue contract to include Failer and update JobStorer. |
| contracts/queue/failer.go | Added contracts for Failer and FailedJob interfaces. |
| func TaskToJson(task contractsqueue.Task, json foundation.Json) (string, error) { | ||
| chain := make([]Job, len(task.Chain)) | ||
| for i, taskData := range task.Chain { | ||
| var chain []Job |
There was a problem hiding this comment.
Consider preallocating the 'chain' slice using make([]Job, 0, len(task.Chain)) to avoid potential reallocations when appending and improve performance.
Suggested change
| var chain []Job | |
| chain := make([]Job, 0, len(task.Chain)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
✅ Checks