Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1047 +/- ##
==========================================
+ Coverage 70.54% 71.07% +0.53%
==========================================
Files 176 178 +2
Lines 12330 12446 +116
==========================================
+ Hits 8698 8846 +148
+ Misses 3252 3211 -41
- Partials 380 389 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| Driver(connection string) string | ||
| FailedDatabase() string | ||
| FailedTable() string | ||
| QueueKey(connection, queue string) string |
There was a problem hiding this comment.
Different drivers have different queue keys, so it should be decided by the drivers.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 0421088 | Previous: 727d072 | Ratio |
|---|---|---|---|
BenchmarkFile_ReadWrite |
355723 ns/op 6185 B/op 97 allocs/op |
203132 ns/op 6186 B/op 97 allocs/op |
1.75 |
BenchmarkFile_ReadWrite - ns/op |
355723 ns/op |
203132 ns/op |
1.75 |
This comment was automatically generated by workflow using github-action-benchmark.
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Is it appropriate to use panic here?
There was a problem hiding this comment.
Yes, we want to keep the fluent flow: facades.Queue().Worker().Run()
📑 Description
Closes goravel/goravel#651
✅ Checks