chore: Update Carbon dependency to v2.6.6#1032
Merged
hwbrzzl merged 12 commits intogoravel:masterfrom May 19, 2025
go-libraries:carbon2.6.x
Merged
chore: Update Carbon dependency to v2.6.6#1032hwbrzzl merged 12 commits intogoravel:masterfrom go-libraries:carbon2.6.x
hwbrzzl merged 12 commits intogoravel:masterfrom
go-libraries:carbon2.6.x
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Carbon dependency to v2.6.5 and adjusts the corresponding API calls in the codebase.
- Updates the version in both go.mod and tests/go.mod
- Replaces the deprecated ParseWithLayouts and ParseWithFormats calls with the new ParseByLayouts and ParseByFormats respectively
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/go.mod | Updated Carbon dependency version from v2.6.4 to v2.6.5 |
| support/carbon/carbon.go | Replaced ParseWithLayouts/ParseWithFormats with ParseByLayouts/ParseByFormats |
| go.mod | Updated Carbon dependency version from v2.6.4 to v2.6.5 |
Comments suppressed due to low confidence (2)
support/carbon/carbon.go:58
- Verify that the associated documentation and comments have been updated to reflect the change from ParseWithLayouts to ParseByLayouts per the Carbon v2.6.5 update.
c = carbon.ParseByLayouts(value, v, timezone...)
support/carbon/carbon.go:69
- Verify that the associated documentation and comments have been updated to reflect the change from ParseWithFormats to ParseByFormats per the Carbon v2.6.5 update.
c = carbon.ParseByFormats(value, v, timezone...)
Contributor
Author
|
Review Ready |
devhaozi
previously approved these changes
May 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1032 +/- ##
=======================================
Coverage 70.48% 70.48%
=======================================
Files 176 176
Lines 12339 12339
=======================================
Hits 8697 8697
Misses 3261 3261
Partials 381 381 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes https://github.com/goravel/goravel/issues/
✅ Checks