chore: add support for custom spinner messages in ExecuteCommand#1031
Merged
chore: add support for custom spinner messages in ExecuteCommand#1031
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom spinner messages when executing commands. It introduces a variadic parameter in the ExecuteCommand function and updates the associated test to verify this new behavior.
- Added a variadic message parameter to ExecuteCommand to allow custom spinner messages.
- Updated execute_test.go to include a test case for executing a command with a custom spinner message.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| support/console/execute_test.go | Added test case to assert spinner message handling |
| support/console/execute.go | Refactored ExecuteCommand to accept optional custom spinner message |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
=======================================
Coverage 70.40% 70.40%
=======================================
Files 176 176
Lines 12318 12321 +3
=======================================
+ Hits 8672 8675 +3
Misses 3265 3265
Partials 381 381 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes https://github.com/goravel/goravel/issues/
✅ Checks