Skip to content

workflow: optimzie govulncheck#1027

Merged
devhaozi merged 2 commits intomasterfrom
haozi/ci
May 9, 2025
Merged

workflow: optimzie govulncheck#1027
devhaozi merged 2 commits intomasterfrom
haozi/ci

Conversation

@devhaozi
Copy link
Member

@devhaozi devhaozi commented May 9, 2025

📑 Description

Closes https://github.com/goravel/goravel/issues/

当前 govulncheck 是定时运行的,提醒不够明显。

✅ Checks

  • Added test cases for my code

Copilot AI review requested due to automatic review settings May 9, 2025 07:15
@devhaozi devhaozi requested a review from a team as a code owner May 9, 2025 07:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the govulncheck workflow by updating the lint workflow configuration and removing the standalone govulncheck workflow file.

  • Added a new govulncheck job to the lint workflow.
  • Removed the file .github/workflows/govulncheck.yml.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/lint.yml Added govulncheck job to invoke govulncheck workflow configuration.
.github/workflows/govulncheck.yml Removed the govulncheck workflow file contents.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 6e81730 Previous: be9dbad Ratio
Benchmark_Fatal 2e-7 ns/op 0 B/op 0 allocs/op 1e-7 ns/op 0 B/op 0 allocs/op 2
Benchmark_Fatal - ns/op 2e-7 ns/op 1e-7 ns/op 2

This comment was automatically generated by workflow using github-action-benchmark.

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.19%. Comparing base (be9dbad) to head (6e81730).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1027   +/-   ##
=======================================
  Coverage   70.19%   70.19%           
=======================================
  Files         176      176           
  Lines       12376    12376           
=======================================
  Hits         8687     8687           
  Misses       3310     3310           
  Partials      379      379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhaozi devhaozi merged commit ca850b4 into master May 9, 2025
12 of 14 checks passed
@devhaozi devhaozi deleted the haozi/ci branch May 9, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants