Skip to content

feat: optimize queue log#1026

Merged
hwbrzzl merged 2 commits intomasterfrom
bowen/optimize-queue-log
May 9, 2025
Merged

feat: optimize queue log#1026
hwbrzzl merged 2 commits intomasterfrom
bowen/optimize-queue-log

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented May 8, 2025

📑 Description

This pull request introduces several updates across the codebase, focusing on refactoring, improving logging, and enhancing modularity. The most significant changes include splitting the Default method in the queue configuration into more granular methods, adding detailed logging for worker tasks, and refactoring the TwoColumnDetail logic into a reusable utility function.

image image

✅ Checks

  • Added test cases for my code

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: fadb7f6 Previous: be9dbad Ratio
Benchmark_Fatal 2e-7 ns/op 0 B/op 0 allocs/op 1e-7 ns/op 0 B/op 0 allocs/op 2
Benchmark_Fatal - ns/op 2e-7 ns/op 1e-7 ns/op 2

This comment was automatically generated by workflow using github-action-benchmark.

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 84.44444% with 14 lines in your changes missing coverage. Please review.

Project coverage is 70.20%. Comparing base (be9dbad) to head (f5e91d3).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
queue/worker.go 81.25% 6 Missing and 3 partials ⚠️
queue/application.go 0.00% 3 Missing ⚠️
console/cli_context.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   70.19%   70.20%   +0.01%     
==========================================
  Files         176      176              
  Lines       12376    12432      +56     
==========================================
+ Hits         8687     8728      +41     
- Misses       3310     3322      +12     
- Partials      379      382       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hwbrzzl hwbrzzl marked this pull request as ready for review May 8, 2025 10:28
@hwbrzzl hwbrzzl requested a review from a team as a code owner May 8, 2025 10:28
Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl merged commit ecdd1e5 into master May 9, 2025
13 checks passed
@hwbrzzl hwbrzzl deleted the bowen/optimize-queue-log branch May 9, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants