feat: update Carbon dependency to v2.6.x#1018
Merged
hwbrzzl merged 35 commits intogoravel:masterfrom May 11, 2025
go-libraries:carbon2.6.4
Merged
feat: update Carbon dependency to v2.6.x#1018hwbrzzl merged 35 commits intogoravel:masterfrom go-libraries:carbon2.6.4
v2.6.x#1018hwbrzzl merged 35 commits intogoravel:masterfrom
go-libraries:carbon2.6.4
Conversation
v2.6.xv2.6.x
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
+ Coverage 70.20% 70.35% +0.14%
==========================================
Files 176 176
Lines 12432 12297 -135
==========================================
- Hits 8728 8651 -77
+ Misses 3322 3265 -57
+ Partials 382 381 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
The CI is stuck; close and reopen it. |
Contributor
|
FYI, Test External failed. |
v2.6.xv2.6.x
Closed
1 task
devhaozi
reviewed
May 10, 2025
support/carbon/carbon.go
Outdated
Comment on lines
+31
to
+32
| // CleanTestNow cleans the test time. | ||
| func CleanTestNow() { |
Member
There was a problem hiding this comment.
Suggested change
| // CleanTestNow cleans the test time. | |
| func CleanTestNow() { | |
| // ClearTestNow cleans the test time. | |
| func ClearTestNow() { |
Member
There was a problem hiding this comment.
Should `Clean` be fine?
I think clear is better.
Contributor
Author
There was a problem hiding this comment.
According to the official documentation of PHP Carbon, clear may be better
devhaozi
reviewed
May 10, 2025
support/carbon/carbon_test.go
Outdated
| Israel, Jamaica, Japan, Libya, Poland, Portugal, PRC, Singapore, Turkey, Shanghai, Chongqing, Harbin, Urumqi, | ||
| HongKong, Macao, Taipei, Tokyo, Saigon, Seoul, Bangkok, Dubai, NewYork, LosAngeles, Chicago, Moscow, London, | ||
| Berlin, Paris, Rome, Sydney, Melbourne, Darwin} | ||
| func TestCleanTestNow(t *testing.T) { |
…, `ParseWithFormats` method into `ParseByFormat` method using generics,
Contributor
Author
|
Review Ready |
devhaozi
reviewed
May 10, 2025
support/carbon/carbon.go
Outdated
Comment on lines
26
to
27
| // Deprecated: it will be removed in the future, use ClearTestNow instead. | ||
| // UnsetTestNow unsets the test time. |
Member
There was a problem hiding this comment.
Suggested change
| // Deprecated: it will be removed in the future, use ClearTestNow instead. | |
| // UnsetTestNow unsets the test time. | |
| // UnsetTestNow unsets the test time. | |
| // Deprecated: it will be removed in the future, use ClearTestNow instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Update Carbon dependency from v2.5.4 to v2.6.4
Close goravel/goravel#645
✅ Checks