Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/modify/utils.go:47
- Direct type assertions on file.Decls[0] may cause a panic if the parsed file structure does not match the expected format. Consider adding explicit type checks before accessing Decorations to ensure stability.
expr.Decorations().Start = file.Decls[0].(*dst.GenDecl).Decorations().Start
packages/match/match.go:260
- Removing the call to dstutil.Unparen may lead to incorrect comparisons of parenthesized expressions. Ensure that this change is intentional and that tests cover cases with extra parentheses.
dstutil.Unparen(x)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1012 +/- ##
=======================================
Coverage 70.72% 70.73%
=======================================
Files 170 170
Lines 11617 11620 +3
=======================================
+ Hits 8216 8219 +3
Misses 3048 3048
Partials 353 353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes https://github.com/goravel/goravel/issues/
✅ Checks