feat: GetDeep function to support nested map lookups#650
feat: GetDeep function to support nested map lookups#650kadirgun wants to merge 1 commit intogoravel:masterfrom kadirgun:master
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
hwbrzzl
left a comment
There was a problem hiding this comment.
Thanks for your PR, and yes, it can indeed be implemented by Reflect.
But it contains many any, we have to assert them. In actual use, the structure (map[string]map[string]map[string]any) rarely, and doesn't recommend. We are using generics to implement other methods, so I think the GetDeep method is not very good for us.
Anyway, I appreciate your PR, Welcome any thoughts.
📑 Description
Closes goravel/goravel#498
@coderabbitai summary
✅ Checks