Skip to content

feat: optimize the ctx parameter#625

Merged
devhaozi merged 4 commits intov1.14.xfrom
bowen/optimize-shutdown
Sep 7, 2024
Merged

feat: optimize the ctx parameter#625
devhaozi merged 4 commits intov1.14.xfrom
bowen/optimize-shutdown

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Sep 6, 2024 •
edited
Loading

📑 Description

The ctx is unnecessary, change it to ...context.Context. @zxdstyle

@coderabbitai summary

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 6, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • 🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hwbrzzl hwbrzzl changed the title feat: remove the ctx parameter feat: optimize the ctx parameter Sep 6, 2024
@devhaozi devhaozi closed this Sep 7, 2024
@devhaozi devhaozi reopened this Sep 7, 2024
devhaozi
devhaozi approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.14.x@05476fa). Learn more about missing BASE report.

Additional details and impacted files 
@@            Coverage Diff             @@
##             v1.14.x     #625   +/-   ##
==========================================
  Coverage           ?   70.35%           
==========================================
  Files              ?      176           
  Lines              ?    10978           
  Branches           ?        0           
==========================================
  Hits               ?     7724           
  Misses             ?     2686           
  Partials           ?      568

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devhaozi devhaozi merged commit 476b554 into v1.14.x Sep 7, 2024
@devhaozi devhaozi deleted the bowen/optimize-shutdown branch September 7, 2024 06:31
hwbrzzl added a commit that referenced this pull request Mar 12, 2025
@hwbrzzl
fix: [#625] Throttle doesn't work when using the Redis cache driver
25cb81c
hwbrzzl added a commit that referenced this pull request Mar 14, 2025
@hwbrzzl
fix: [#625] Throttle doesn't work when using the Redis cache driver (#…
9f0f6a6 
…955)

* fix: [#625] Throttle doesn't work when using the Redis cache driver

* add some logic

* chore: update mocks

* fix main logic

* Fix store_test.go to properly mock Lock.Release method and handle invalid JSON

* Implement rate limiting functionality with tests

* fix test

* fix test

* fix lint

* optimize Block

---------

Co-authored-by: hwbrzzl <24771476+hwbrzzl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devhaozi devhaozi devhaozi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hwbrzzl @devhaozi