Skip to content

feat: Remove AddFilter method from validation facade#592

Merged
krishankumar01 merged 2 commits intomasterfrom
kkumar-gcc/remove-addfilter
Aug 9, 2024
Merged

feat: Remove AddFilter method from validation facade#592
krishankumar01 merged 2 commits intomasterfrom
kkumar-gcc/remove-addfilter

Conversation

@krishankumar01
Copy link
Member

@krishankumar01 krishankumar01 commented Aug 9, 2024

📑 Description

Closes https://github.com/goravel/goravel/issues/?

@coderabbitai summary

✅ Checks

  • Added test cases for my code

@krishankumar01 krishankumar01 requested a review from a team as a code owner August 9, 2024 15:44
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 9, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • 🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@krishankumar01 krishankumar01 reopened this Aug 9, 2024
@codecov
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.08%. Comparing base (e2d76ce) to head (42ec818).

Files Patch % Lines
validation/validation.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
- Coverage   70.09%   70.08%   -0.01%     
==========================================
  Files         182      182              
  Lines       11302    11299       -3     
==========================================
- Hits         7922     7919       -3     
  Misses       2805     2805              
  Partials      575      575

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hwbrzzl
hwbrzzl approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krishankumar01 krishankumar01 merged commit c6c23a4 into master Aug 9, 2024
@krishankumar01 krishankumar01 deleted the kkumar-gcc/remove-addfilter branch August 9, 2024 16:10
almas-x added a commit that referenced this pull request Feb 11, 2025
@almas-x
feat: [#592] Add --no-ansi flag to disable color output in Artisan co…
ceb2433 
…mmands
almas-x added a commit that referenced this pull request Feb 11, 2025
@almas-x
feat: [#592] Add --no-ansi flag to disable color output in Artisan co…
89a19f9 
…mmands
almas-x added a commit that referenced this pull request Feb 11, 2025
@almas-x
feat: [#592] Add --no-ansi flag to disable color output in Artisan co…
6280320 
…mmands
almas-x added a commit that referenced this pull request Feb 11, 2025
@almas-x
feat: [#592] Add --no-ansi flag to disable color output in Artisan co…
e3947a5 
…mmands
almas-x added a commit that referenced this pull request Feb 11, 2025
@almas-x
feat: [#592] Add --no-ansi flag to disable color output in Artisan co…
b98b64f 
…mmands
@coderabbitai coderabbitai bot mentioned this pull request Feb 11, 2025
Merged
1 task
almas-x added a commit that referenced this pull request Feb 11, 2025
@almas-x
feat: [#592] Add --no-ansi flag to disable color output in Artisan co… (
a113be2 
#880)

* feat: [#592] Add --no-ansi flag to disable color output in Artisan commands

* optimize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krishankumar01 @hwbrzzl