fix: Update MAC prefixes and generation logic#138
Merged
mosajjal merged 2 commits intogopacket:masterfrom Oct 28, 2025
Merged
Conversation
Contributor
dreadl0ck
commented
Oct 24, 2025
- Change IEEE OUI database URL from HTTP to HTTPS
- Add custom User-Agent header to avoid bot blocking (received HTTP 418 with go user agent)
- Regenerate valid_mac_prefixes.go with current data from IEEE
…-Agent - Change IEEE OUI database URL from HTTP to HTTPS - Add custom User-Agent header to avoid bot blocking (HTTP 418) - Regenerate valid_mac_prefixes.go with current data from IEEE - Add FIX_SUMMARY.md documenting the issue and solution
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the MAC prefix generator script that was producing empty output due to HTTP redirect issues and bot blocking by the IEEE server. The changes enable successful fetching and regeneration of the MAC address prefix database.
Key Changes:
- Updated IEEE OUI database URL from HTTP to HTTPS
- Added custom User-Agent header to bypass bot detection (HTTP 418 response)
- Regenerated valid_mac_prefixes.go with current IEEE data
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| macs/gen.go | Updated URL to HTTPS and implemented custom HTTP request with User-Agent header to avoid bot blocking |
| macs/FIX_SUMMARY.md | Added documentation explaining the problem, root causes, changes made, and testing approach |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
hey. I don't really need the .md file for the fix. please remove and commit so I can merge this. |
Contributor
Author
|
done - thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.