Fix Dot11InformationElement parsing panic#124
Merged
mosajjal merged 1 commit intogopacket:masterfrom Aug 31, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential slice panic in Dot11InformationElement parsing when the calculated offset exceeds the available data length. The fix adds bounds checking for vendor extension (ID 221) and extension element (ID 255) parsing to prevent out-of-bounds slice operations.
- Adds a helper function
checkOffsetLengthto validate offset bounds before slice operations - Implements bounds checking for vendor extension (ID 221) and extension element (ID 255) parsing
- Includes a regression test case that would trigger the panic on unpatched code
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| layers/dot11.go | Adds bounds checking helper and validation for vendor/extension element parsing |
| layers/dot11_test.go | Adds test case to verify the fix prevents slice panic with malformed data |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Possible for the offset+4 to be greater than offset+m.Length resulting in a slice panic. Protect 221 and 255 which a check to ensure the start of the slice isn't greater.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible for the offset+4 to be greater than offset+m.Length resulting in a slice panic. Protect 221 and 255 which a check to ensure the start of the slice isn't greater.
Associated test will cause the panic on un-patched code with out of bounds slice.