fix: preserve nested JSON tag paths in error keys#309
Merged
inhere merged 1 commit intogookit:masterfrom Sep 3, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 17399837106Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where error keys for nested JSON structures were not preserving the full JSON tag paths, instead returning incomplete field names. The fix ensures that when validating nested arrays and structs with JSON tags, the error keys correctly reflect the complete JSON path.
Key changes:
- Enhanced error key generation to preserve JSON tag paths in nested structures
- Added comprehensive test coverage for both regular struct fields and JSON-tagged fields
- Updated existing test assertions to reflect the corrected error key format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| issues_test.go | Added test cases for issue #297 and updated existing test assertions to match corrected error key format |
| data_source.go | Enhanced array/slice processing to maintain JSON tag paths in error keys for nested structures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #297
close #282