chore: Manage errorprone and j2objc versions in pom-parent#3948
Conversation
Summary of ChangesHello @lqiu96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request centralizes the management of 'errorprone' and 'j2objc-annotations' dependency versions. By removing their explicit version declarations from 'java-shared-dependencies/third-party-dependencies/pom.xml', these versions are now expected to be inherited from a parent POM, streamlining dependency version control across the project. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the management of errorprone.version and j2objc-annotations.version by moving their definitions to the parent POM. This is a good practice for centralizing dependency version management and improving maintainability. The changes in java-shared-dependencies/third-party-dependencies/pom.xml correctly remove the now-redundant properties. The change is clean and I see no issues.
|
|
Versions are managed here: https://github.com/googleapis/sdk-platform-java/blob/1962491d13a03621e023a437370a25c446327b72/gapic-generator-java-pom-parent/pom.xml#L37-L38 third-party-deps pom already inherits from pom-parent, so there should not be any difference: https://github.com/googleapis/sdk-platform-java/blob/1962491d13a03621e023a437370a25c446327b72/java-shared-dependencies/third-party-dependencies/pom.xml#L15-L20
Versions are managed here:
sdk-platform-java/gapic-generator-java-pom-parent/pom.xml
Lines 37 to 38 in 1962491
third-party-deps pom already inherits from pom-parent, so there should not be any difference:
sdk-platform-java/java-shared-dependencies/third-party-dependencies/pom.xml
Lines 15 to 20 in 1962491