Skip to content

feat(experimental): Handle BidiReadObjectRedirectedError for bidi reads #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pulkit0110 merged 4 commits into from
Nov 5, 2025
Merged

feat(experimental): Handle BidiReadObjectRedirectedError for bidi reads #1600

Pulkit0110 merged 4 commits into from
Nov 5, 2025

Conversation

@Pulkit0110
Copy link
Member

@Pulkit0110 Pulkit0110 commented Nov 3, 2025

Added implementation to extract routing_token from BidiReadObjectRedirectedError.

@Pulkit0110 Pulkit0110 requested review from a team as code owners November 3, 2025 11:31
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Nov 3, 2025
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 3, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 3, 2025

Summary of Changes

Hello @Pulkit0110, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an experimental feature to enhance the resilience and efficiency of bidirectional read operations by implementing a structured approach to stream resumption. It establishes an abstract framework for handling various bidi operations and provides a specific strategy for reads that intelligently manages download state and, crucially, extracts routing tokens from redirection errors to facilitate seamless recovery.

Highlights

  • Introduced Abstract Resumption Strategy: A new abstract base class _BaseResumptionStrategy is added to define a common interface for handling bidi stream resumption, allowing for pluggable, service-specific logic.
  • Implemented Bidi Read Resumption: A concrete implementation, _ReadResumptionStrategy, is provided for bidi read operations, managing download state, generating read requests, and processing server responses.
  • Handled BidiReadObjectRedirectedError: The _ReadResumptionStrategy now includes logic to specifically catch BidiReadObjectRedirectedError during failure recovery and extract the routing_token to update the operation's state.
  • Added Comprehensive Unit Tests: New unit tests were introduced to validate the functionality of the _DownloadState helper class and the _ReadResumptionStrategy, including tests for request generation, state updates, data corruption scenarios, and the new error redirection handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a resumption strategy for bidi reads, including handling for BidiReadObjectRedirectedError. The implementation adds a base strategy class, a concrete strategy for reads, and corresponding unit tests. My review has identified a couple of critical issues in the implementation and tests for handling the redirect error that will prevent the feature from working as intended. I've also included some suggestions to improve the design and type safety of the state management and the base strategy class, which will enhance maintainability.

chandra-siri
chandra-siri previously approved these changes Nov 4, 2025
View reviewed changes
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: l Pull request size is large. labels Nov 5, 2025
@Pulkit0110 Pulkit0110 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2025
@Pulkit0110 Pulkit0110 merged commit 71b0f8a into googleapis:main Nov 5, 2025
15 checks passed
@release-please release-please bot mentioned this pull request Nov 5, 2025
Merged
@Pulkit0110 Pulkit0110 deleted the bidi-reads-retry3 branch January 2, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chandra-siri chandra-siri chandra-siri approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chandra-siri chandra-siri

Labels

api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pulkit0110 @chandra-siri @parthea