-
Notifications
You must be signed in to change notification settings - Fork 168
feat(experimental): Add read resumption strategy #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Pulkit0110, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an experimental framework for implementing read resumption strategies for bidirectional (bidi) reads. It establishes an abstract base class for defining how to generate requests, update state from responses, and recover from failures during bidi operations. A concrete implementation for bidi reads is provided, which intelligently manages download state, generates requests for incomplete data segments, and includes robust integrity checks to prevent data corruption. This enhancement aims to improve the reliability and efficiency of large object downloads by enabling seamless resumption of interrupted transfers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a read resumption strategy for bidi reads, including an abstract base class and a concrete implementation for reads. The changes are well-structured and include comprehensive unit tests. My review includes a critical fix for the _BaseResumptionStrategy abstract class, where a method signature was incorrect, which would cause a runtime error. I've also included some suggestions to improve code quality by removing unused imports and adding type hints for better maintainability.
google/cloud/storage/_experimental/asyncio/retry/reads_resumption_strategy.py
Outdated
Show resolved
Hide resolved
google/cloud/storage/_experimental/asyncio/retry/reads_resumption_strategy.py
Outdated
Show resolved
Hide resolved
53813e4 to
538a1b9
Compare
Adding the read resumption strategy for bidi reads. It will support
generate_requestsandupdate_state_from_responsemethods