Skip to content

Conversation

@Pulkit0110
Copy link
Member

Adding the read resumption strategy for bidi reads. It will support generate_requests and update_state_from_response methods

@Pulkit0110 Pulkit0110 requested review from a team as code owners November 3, 2025 09:41
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Nov 3, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Pulkit0110, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an experimental framework for implementing read resumption strategies for bidirectional (bidi) reads. It establishes an abstract base class for defining how to generate requests, update state from responses, and recover from failures during bidi operations. A concrete implementation for bidi reads is provided, which intelligently manages download state, generates requests for incomplete data segments, and includes robust integrity checks to prevent data corruption. This enhancement aims to improve the reliability and efficiency of large object downloads by enabling seamless resumption of interrupted transfers.

Highlights

  • New Abstract Base Class: Introduced _BaseResumptionStrategy to define a common interface for bidi stream resumption, including abstract methods for generating requests, updating state from responses, and recovering from failures.
  • Concrete Read Resumption Strategy: Added _ReadResumptionStrategy, a concrete implementation for bidi reads, which manages download state and handles request generation and response processing.
  • Download State Management: Implemented _DownloadState to track the progress of individual download ranges, including initial offset, length, bytes written, and completion status.
  • Intelligent Request Generation: The generate_requests method now intelligently creates ReadRange requests only for the incomplete portions of a download, enabling 'smarter resumption' of interrupted transfers.
  • Response Processing and Integrity Checks: The update_state_from_response method processes incoming data, performs offset verification, writes data to a user buffer, and checks for byte count mismatches upon range completion, raising DataCorruption if issues are found.
  • Error Recovery Framework: The recover_state_on_failure method is defined as an async abstract method, intended for future implementation of error handling logic, such as extracting routing tokens for redirects.
  • Comprehensive Unit Tests: New unit tests ensure the correct behavior of _DownloadState and _ReadResumptionStrategy across various scenarios, including successful operations, partial downloads, and error conditions like data corruption.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a read resumption strategy for bidi reads, including an abstract base class and a concrete implementation for reads. The changes are well-structured and include comprehensive unit tests. My review includes a critical fix for the _BaseResumptionStrategy abstract class, where a method signature was incorrect, which would cause a runtime error. I've also included some suggestions to improve code quality by removing unused imports and adding type hints for better maintainability.

@Pulkit0110 Pulkit0110 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2025
@Pulkit0110 Pulkit0110 enabled auto-merge (squash) November 5, 2025 06:26
@Pulkit0110 Pulkit0110 merged commit 5d5e895 into googleapis:main Nov 5, 2025
15 checks passed
@Pulkit0110 Pulkit0110 deleted the bidi-reads-retry2 branch January 2, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants