Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: convert property fields in graph visualization to strings before sending them to JavaScript#133

Merged
tswast merged 7 commits intomainfrom
fix
Aug 21, 2025
Merged

fix: convert property fields in graph visualization to strings before sending them to JavaScript#133
tswast merged 7 commits intomainfrom
fix

Conversation

@ericfe-google
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…script.

This avoids possible truncation in the Javascript layer when converting the JSON into Javascript objects, for example, converting a 64-bit integer into a Number.
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-magics API. labels Aug 21, 2025
@ericfe-google ericfe-google marked this pull request as ready for review August 21, 2025 22:39
@ericfe-google ericfe-google requested a review from a team as a code owner August 21, 2025 22:39
@ericfe-google ericfe-google requested review from a team, suzmue and sycai August 21, 2025 22:39
@ericfe-google ericfe-google assigned tswast and unassigned shollyman Aug 21, 2025
@tswast tswast changed the title chore: Convert property fields to strings before sending them to Javascript. fix: convert property fields in graph visualization to strings before sending them to JavaScript Aug 21, 2025
@tswast tswast merged commit f869a61 into main Aug 21, 2025
21 of 22 checks passed
@tswast tswast deleted the fix branch August 21, 2025 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-magics API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants