Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

deps: drop support for Python 3.7 and 3.8#127

Merged
tswast merged 22 commits intomainfrom
tswast-3-8
Jul 10, 2025
Merged

deps: drop support for Python 3.7 and 3.8#127
tswast merged 22 commits intomainfrom
tswast-3-8

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Jul 7, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested a review from a team as a code owner July 7, 2025 17:08
@tswast tswast requested review from a team, shobsi and whuffman36 July 7, 2025 17:08
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-magics API. labels Jul 7, 2025
@tswast tswast added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: bigquery Issues related to the googleapis/python-bigquery-magics API. labels Jul 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
@tswast tswast added owlbot:run Add this label to trigger the Owlbot post processor. api: bigquery Issues related to the googleapis/python-bigquery-magics API. labels Jul 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
tswast
tswast commented Jul 7, 2025
View reviewed changes
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
tswast
tswast commented Jul 7, 2025
View reviewed changes
tswast
tswast commented Jul 7, 2025
View reviewed changes
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
@tswast tswast requested review from GarrettWu and removed request for shobsi July 7, 2025 18:53
@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Jul 7, 2025 •
edited
Loading

@GarrettWu I believe this is now ready for review. Mind taking a look?

Edit: Python 3.7 and 3.8 test failures are expected. I have cl/780163517 ready to go to stop running these tests, to merge alongside this PR.

shobsi
shobsi reviewed Jul 9, 2025
View reviewed changes
CONTRIBUTING.rst

- The feature must work fully on the following CPython versions:
3.7, 3.8, 3.9, 3.11, 3.12 and 3.13 on both UNIX and Windows.
3.9, 3.11, 3.12 and 3.13 on both UNIX and Windows.
Copy link
Copy Markdown
Contributor

@shobsi shobsi Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why version 3.10 is omitted

Copy link
Copy Markdown
Contributor Author

@tswast tswast Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's derived from which ones we unit test against.

@tswast tswast enabled auto-merge (squash) July 10, 2025 18:21
@tswast tswast disabled auto-merge July 10, 2025 18:21
@tswast tswast merged commit 2a8e9de into main Jul 10, 2025
22 of 25 checks passed
@tswast tswast deleted the tswast-3-8 branch July 10, 2025 18:21
@release-please release-please bot mentioned this pull request Jul 10, 2025
Merged
@tswast tswast mentioned this pull request Aug 4, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@whuffman36 whuffman36 Awaiting requested review from whuffman36

2 more reviewers

@shobsi shobsi shobsi left review comments

@GarrettWu GarrettWu GarrettWu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@drylks-work drylks-work

Labels

api: bigquery Issues related to the googleapis/python-bigquery-magics API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast @GarrettWu @shobsi @drylks-work