fix(skills): fix integer parameter parsing through agent skills by helloeve · Pull Request #2847 · googleapis/mcp-toolbox

helloeve · 2026-03-25T22:11:26Z

This PR fixes an issue where integer parameters were incorrectly parsed as float64 when invoking tools via the CLI.

Co-authored-by: Pavan Krishna Rampalli pavanrampalli@google.com

gemini-code-assist · 2026-03-25T22:11:37Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug that caused integer parameters to be misinterpreted as floating-point numbers during tool invocation through the command-line interface. By introducing a more robust JSON decoding mechanism and adding a dedicated test, the change ensures that numerical parameters are correctly typed, improving the reliability and accuracy of tool execution.

Highlights

Bug Fix: Resolved an issue where integer parameters were incorrectly parsed as float64 when invoking tools via the CLI.
JSON Decoding: Replaced the standard json.Unmarshal with a custom util.DecodeJSON function to ensure correct type handling during parameter parsing.
Test Coverage: Added a new test case to validate the correct parsing of integer parameters for tool invocations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the JSON parameter decoding in the invoke command to utilize a new util.DecodeJSON function, which now accepts an io.Reader for improved input handling. It also introduces a new sqlite-sql tool named int-tool that processes integer parameters, accompanied by a new test case to validate its invocation. There is no feedback to provide on the review comments.

Yuan325 · 2026-03-25T22:26:13Z

Duplicate of #2845. Please close that PR once this is merge :) Thank you @pavankrishna13 and @helloeve

…ough-agent-skills

This PR fixes an issue where integer parameters were incorrectly parsed as float64 when invoking tools via the CLI. Co-authored-by: Pavan Krishna Rampalli <pavanrampalli@google.com> --------- Co-authored-by: Pavan Krishna Rampalli <pavanrampalli@google.com>

🤖 I have created a release *beep* *boop* --- ## [0.31.0](v0.30.0...v0.31.0) (2026-03-26) ### ⚠ BREAKING CHANGES * release upgraded docsite ([#2831](#2831)) * **http:** sanitize non-2xx error output ([#2654](#2654)) * add a new `enable-api` flag ([#2846](#2846)) * remove deprecations and update tools-file flag ([#2806](#2806)) ### Features * Add a new `enable-api` flag ([#2846](#2846)) ([7a070da](7a070da)) * **auth:** Add generic `authService` type for MCP ([#2619](#2619)) ([f6678f8](f6678f8)) * **auth:** Add Protected Resource Metadata endpoint ([#2698](#2698)) ([b53dcf2](b53dcf2)) * **auth:** Support manual PRM override ([#2717](#2717)) ([283e4e3](283e4e3)) * **dataplex:** Add support for lookup context tool. ([#2744](#2744)) ([facb69d](facb69d)) * Remove deprecations and update tools-file flag ([#2806](#2806)) ([ab64c95](ab64c95)) ### Bug Fixes * **ci:** Remove search index generation from preview deployment workflow ([#2859](#2859)) ([f8891b8](f8891b8)) * **docs:** Skip empty folders in pagination & reduce PR comment noise ([#2853](#2853)) ([9ebd93a](9ebd93a)) * **http:** Sanitize non-2xx error output ([#2654](#2654)) ([5bef954](5bef954)) * **skills:** Fix integer parameter parsing through agent skills ([#2847](#2847)) ([4564efe](4564efe)) ### Documentation * Release upgraded docsite ([#2831](#2831)) ([5b25ce0](5b25ce0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.31.0](v0.30.0...v0.31.0) (2026-03-26) ### ⚠ BREAKING CHANGES * release upgraded docsite ([#2831](#2831)) * **http:** sanitize non-2xx error output ([#2654](#2654)) * add a new `enable-api` flag ([#2846](#2846)) * remove deprecations and update tools-file flag ([#2806](#2806)) ### Features * Add a new `enable-api` flag ([#2846](#2846)) ([7a070da](7a070da)) * **auth:** Add generic `authService` type for MCP ([#2619](#2619)) ([f6678f8](f6678f8)) * **auth:** Add Protected Resource Metadata endpoint ([#2698](#2698)) ([b53dcf2](b53dcf2)) * **auth:** Support manual PRM override ([#2717](#2717)) ([283e4e3](283e4e3)) * **dataplex:** Add support for lookup context tool. ([#2744](#2744)) ([facb69d](facb69d)) * Remove deprecations and update tools-file flag ([#2806](#2806)) ([ab64c95](ab64c95)) ### Bug Fixes * **ci:** Remove search index generation from preview deployment workflow ([#2859](#2859)) ([f8891b8](f8891b8)) * **docs:** Skip empty folders in pagination & reduce PR comment noise ([#2853](#2853)) ([9ebd93a](9ebd93a)) * **http:** Sanitize non-2xx error output ([#2654](#2654)) ([5bef954](5bef954)) * **skills:** Fix integer parameter parsing through agent skills ([#2847](#2847)) ([4564efe](4564efe)) ### Documentation * Release upgraded docsite ([#2831](#2831)) ([5b25ce0](5b25ce0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> c6b811c

🤖 I have created a release *beep* *boop* --- ## [0.31.0](googleapis/mcp-toolbox@v0.30.0...v0.31.0) (2026-03-26) ### ⚠ BREAKING CHANGES * release upgraded docsite ([googleapis#2831](googleapis#2831)) * **http:** sanitize non-2xx error output ([googleapis#2654](googleapis#2654)) * add a new `enable-api` flag ([googleapis#2846](googleapis#2846)) * remove deprecations and update tools-file flag ([googleapis#2806](googleapis#2806)) ### Features * Add a new `enable-api` flag ([googleapis#2846](googleapis#2846)) ([7a070da](googleapis@7a070da)) * **auth:** Add generic `authService` type for MCP ([googleapis#2619](googleapis#2619)) ([f6678f8](googleapis@f6678f8)) * **auth:** Add Protected Resource Metadata endpoint ([googleapis#2698](googleapis#2698)) ([b53dcf2](googleapis@b53dcf2)) * **auth:** Support manual PRM override ([googleapis#2717](googleapis#2717)) ([283e4e3](googleapis@283e4e3)) * **dataplex:** Add support for lookup context tool. ([googleapis#2744](googleapis#2744)) ([facb69d](googleapis@facb69d)) * Remove deprecations and update tools-file flag ([googleapis#2806](googleapis#2806)) ([ab64c95](googleapis@ab64c95)) ### Bug Fixes * **ci:** Remove search index generation from preview deployment workflow ([googleapis#2859](googleapis#2859)) ([f8891b8](googleapis@f8891b8)) * **docs:** Skip empty folders in pagination & reduce PR comment noise ([googleapis#2853](googleapis#2853)) ([9ebd93a](googleapis@9ebd93a)) * **http:** Sanitize non-2xx error output ([googleapis#2654](googleapis#2654)) ([5bef954](googleapis@5bef954)) * **skills:** Fix integer parameter parsing through agent skills ([googleapis#2847](googleapis#2847)) ([4564efe](googleapis@4564efe)) ### Documentation * Release upgraded docsite ([googleapis#2831](googleapis#2831)) ([5b25ce0](googleapis@5b25ce0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> c6b811c

pavankrishna13 and others added 2 commits March 25, 2026 15:26

Bug fix for issue with integer parameter

d19bcb4

fix(skill): fix parameter parsing in tool invocation

f217021

helloeve assigned Yuan325 Mar 25, 2026

helloeve requested a review from a team as a code owner March 25, 2026 22:11

gemini-code-assist Bot reviewed Mar 25, 2026

View reviewed changes

helloeve added the release candidate Use label to signal PR should be included in the next release. label Mar 25, 2026

Yuan325 changed the title ~~Bug fix for issue with integer parameter through agent skills~~ fix(skills): integer parameter through agent skills Mar 25, 2026

Yuan325 changed the title ~~fix(skills): integer parameter through agent skills~~ fix(skills): fix integer parameter parsing through agent skills Mar 25, 2026

Yuan325 approved these changes Mar 25, 2026

View reviewed changes

Merge branch 'main' into Bug-fix-for-issue-with-integer-parameter-thr…

62b3b23

…ough-agent-skills

helloeve merged commit 4564efe into main Mar 25, 2026
19 checks passed

helloeve deleted the Bug-fix-for-issue-with-integer-parameter-through-agent-skills branch March 25, 2026 23:04

release-please Bot mentioned this pull request Mar 25, 2026

chore(main): release 0.31.0 #2814

Merged

pavankrishna13 mentioned this pull request Mar 26, 2026

Fix: Prevent integer to float conversion for tool parameters invoked via agent skills #2845

Closed

6 tasks

BrewTestBot mentioned this pull request Mar 27, 2026

mcp-toolbox 0.31.0 Homebrew/homebrew-core#274467

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(skills): fix integer parameter parsing through agent skills#2847

fix(skills): fix integer parameter parsing through agent skills#2847
helloeve merged 3 commits into
mainfrom
Bug-fix-for-issue-with-integer-parameter-through-agent-skills

helloeve commented Mar 25, 2026

Uh oh!

gemini-code-assist Bot commented Mar 25, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Yuan325 commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

helloeve commented Mar 25, 2026

Uh oh!

gemini-code-assist Bot commented Mar 25, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Yuan325 commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants