Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: pass deadline through ExecuteQuery RetrySettings#2355

Merged
mutianf merged 1 commit into
googleapis:mainfrom
jackdingilian:sql-deadline
Sep 25, 2024
Merged

fix: pass deadline through ExecuteQuery RetrySettings#2355
mutianf merged 1 commit into
googleapis:mainfrom
jackdingilian:sql-deadline

Conversation

@jackdingilian

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@jackdingilian jackdingilian requested review from a team September 25, 2024 15:15
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 25, 2024

@mutianf mutianf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run mvn com.coveo:fmt-maven-plugin:format to fix the format? Thanks!

Change-Id: I47fbb6761205c8ab34ecfa490954c56cf01b5288
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants