Conversation
…-cloud-node into fixSystemTests
feywind
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #6795. Because the logic spliced elements from the array, we were skipping some elements, causing the array to skip removing the other non-default-version system tests. I fixed this by iterating the array backwards.
To confirm the fix, I changed the test that was testing this to point to the actual troublesome library in #6842.
The only logic to check here is packages/gapic-node-processing/src/combine-libraries.ts and packages/gapic-node-processing/test/combine-libraries.test.ts
Edit: turns out that our tests in packages/gapic-node-processing/test/generate-index.test.ts were actually depending on generating the other library (which is wrong), which led me to discover we weren't setting up test fixtures correctly in packages/gapic-node-processing/test/generate-index.test.ts. So I fixed which library we were generating there so tests could run without accidentally relying on the tasks library to be generated in packages/gapic-node-processing/test/combine-libraries.test.ts.