Skip to content

docs(maps-places): add link to client library examples #11597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blakeli0 merged 4 commits into from
May 29, 2025
Merged

docs(maps-places): add link to client library examples #11597

blakeli0 merged 4 commits into from
May 29, 2025

Conversation

@meltsufin
Copy link
Member

@meltsufin meltsufin commented May 29, 2025

b/421118724

@meltsufin meltsufin requested a review from a team as a code owner May 29, 2025 14:25
@meltsufin meltsufin changed the title docs[maps-places]: add link to client library examples docs(maps-places): add link to client library examples May 29, 2025
@meltsufin meltsufin force-pushed the maps-places-examples branch from 756529e to f7d2d0e Compare May 29, 2025 14:28
@meltsufin meltsufin requested a review from blakeli0 May 29, 2025 14:33
@blakeli0
Copy link
Contributor

blakeli0 commented May 29, 2025

README is templated and fully-generated. We should either add this to the generic template or custom .readme-partials.yaml template in each module. For example, .readme-partials.yaml in java-compute.

@meltsufin
Copy link
Member Author

meltsufin commented May 29, 2025

README is templated and fully-generated. We should either add this to the generic template or custom .readme-partials.yaml template in each module. For example, .readme-partials.yaml in java-compute.

Thanks! I replaced it with .readme-partials.yaml. PTAL.

@blakeli0
Copy link
Contributor

blakeli0 commented May 29, 2025

README is templated and fully-generated. We should either add this to the generic template or custom .readme-partials.yaml template in each module. For example, .readme-partials.yaml in java-compute.

Thanks! I replaced it with .readme-partials.yaml. PTAL.

Thanks, LGTM!

Ideally README.md should be re-generated as part of this template change, but the generation process is probably not triggered because there is no proto change. I'll keep on eye on the follow PRs to make sure the README is actually updated.

@blakeli0 blakeli0 merged commit 80a9d63 into main May 29, 2025
32 checks passed
@blakeli0 blakeli0 deleted the maps-places-examples branch May 29, 2025 22:10
@release-please release-please bot mentioned this pull request May 29, 2025
Merged
lqiu96 pushed a commit that referenced this pull request Jun 10, 2025
@meltsufin @lqiu96
docs(maps-places): add link to client library examples (#11597)
04f5d7f 
b/421118724
lqiu96 pushed a commit that referenced this pull request Jun 10, 2025
@meltsufin @lqiu96
docs(maps-places): add link to client library examples (#11597)
072f658 
b/421118724
lqiu96 pushed a commit that referenced this pull request Jul 7, 2025
@meltsufin @lqiu96
docs(maps-places): add link to client library examples (#11597)
1abb8cf 
b/421118724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meltsufin @blakeli0