Skip to content

Conversation

@blakeli0
Copy link
Contributor

@blakeli0 blakeli0 commented Nov 8, 2024

google-cloud-shared-config and google-cloud-shared-dependencies are consolidated into sdk-platform-java-config. The only repo level dependency change in google-cloud-java is sdk-platform-java-config now.

This PR removes the outdated logic in release notes splitting that still looks for google-cloud-shared-config and google-cloud-shared-dependencies, add the logic to propagate sdk-platform-java-config change to each module's release notes.

This PR is dependent on the behavior that sdk-platform-java-config update is in the main release notes at least, which is not happening at this moment because it is a chore. There will be a follow up PR to update the sdk-platform-java-config dependency update to a fix.

@blakeli0 blakeli0 marked this pull request as ready for review November 8, 2024 20:08
@blakeli0 blakeli0 requested a review from a team as a code owner November 8, 2024 20:08
Copy link
Contributor

@JoeWang1127 JoeWang1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@blakeli0 blakeli0 changed the title fix: Propagate repo level dependency change to each module's release notes fix: Propagate repo level dependency change sdk-platform-java-config to each module's release notes Nov 8, 2024
@blakeli0 blakeli0 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Nov 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2024
@blakeli0 blakeli0 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2024
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 9, 2024
@blakeli0 blakeli0 merged commit 6fafcb3 into main Nov 19, 2024
28 checks passed
@blakeli0 blakeli0 deleted the fix-release-notes branch November 19, 2024 14:47
lqiu96 pushed a commit that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants