-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: [privilegedaccessmanager] new module for privilegedaccessmanager #11041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
suztomo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. The API description can be shorter.
| name_pretty: Privileged Access Manager API | ||
| product_documentation: | ||
| https://cloud.google.com/java/docs/reference/google-cloud-privilegedaccessmanager/latest/overview | ||
| api_description: Privileged Access Manager (PAM) helps you on your journey towards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the first sentence to keep it concise, as per https://github.com/googleapis/google-cloud-java/blob/main/generation/new_client_hermetic_build/README.md#api-description-api_description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Updated
|
Closing and re-opening to retrigger the header check |
|
Failed CI from |
#11041) * feat: [privilegedaccessmanager] new module for privilegedaccessmanager * chore: generate libraries at Tue Jul 30 21:53:53 UTC 2024 * chore: Update API Description --------- Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
Generated by @lqiu96 via generate_new_client_hermetic_build.yaml
Command used: