feat: [iap] new module for iap #10905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeWang1127
reviewed
May 31, 2024
| product_documentation: https://cloud.google.com/iap | ||
| api_description: Controls access to cloud applications running on Google Cloud Platform. | ||
| client_documentation: https://cloud.google.com/java/docs/reference/google-cloud-iap/latest/overview | ||
| release_level: stable |
Contributor
There was a problem hiding this comment.
I make the release level as stable
blakeli0
reviewed
May 31, 2024
generation_config.yaml
Outdated
| cloud_api: true | ||
| GAPICs: | ||
| - proto_path: google/cloud/iap/v1 | ||
| - proto_path: google/cloud/iap/v1beta1 |
Contributor
There was a problem hiding this comment.
Did you manually add v1beta1 here? I don't think we still have to generate v1beta1 since v1 is already here. Dotnet also don't have it generated.
This reverts commit a725a34.
…cloud-java into new-library/iap-2aFWj
7766263 to
54a996f
Compare
blakeli0
approved these changes
May 31, 2024
lqiu96
pushed a commit
that referenced
this pull request
Jul 7, 2025
* feat: [iap] new module for iap * chore: generate libraries at Fri May 31 17:49:49 UTC 2024 * add proto path * chore: generate libraries at Fri May 31 17:55:15 UTC 2024 * remove beta * Revert "remove beta" This reverts commit a725a34. * remove beta * regenerate * restore pom * restore config * chore: generate libraries at Fri May 31 18:49:47 UTC 2024 --------- Co-authored-by: Joe Wang <joewa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by @JoeWang1127 via generate_new_client_hermetic_build.yaml
Command used:
b/343507706