test(pubsub): use default MinExtensionPeriod for exactly once tests#8502
Merged
hongalex merged 5 commits intogoogleapis:mainfrom Aug 31, 2023
Merged
test(pubsub): use default MinExtensionPeriod for exactly once tests#8502hongalex merged 5 commits intogoogleapis:mainfrom
hongalex merged 5 commits intogoogleapis:mainfrom
Conversation
shollyman
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8315
What's happening here is that the message is being redelivered in a short time frame, resulting in the context cancellation and thus causing the
ackResult.Get(ctx)call to be cancelled rather than being timed out. Message redelivery can be mitigated by setting a high value forMinExtensionPeriod, or in this case, not setting it at all since the default value is 1 minute.