feat(bigquery): set PreferredMinStreamCount when creating read session#8476
Merged
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:mainfrom Aug 30, 2023
Conversation
shollyman
approved these changes
Aug 29, 2023
Contributor
shollyman
left a comment
There was a problem hiding this comment.
minor nit, but otherwise LGTM
|
|
||
| // Start initiates a read session | ||
| func (rs *readSession) start() error { | ||
| preferredMinStreamCount := int32(0) |
Contributor
There was a problem hiding this comment.
this looks a bit odd, why not just var preferredMinStreamCount int32?
Contributor
Author
There was a problem hiding this comment.
good point, let me change here. I think I was playing with default values and ended up leaving like that.
This was referenced Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreferredMinStreamCountmust be less than or equal toMaxStreamCount, so we only set it when theMaxStreamCountis 0, which basically sets no limit to it.Resolves #8432