Skip to content

chore(storage): fix progress call in gRPC Writer#7872

Merged
tritone merged 2 commits intogoogleapis:mainfrom
tritone:write-progress
May 3, 2023
Merged

chore(storage): fix progress call in gRPC Writer#7872
tritone merged 2 commits intogoogleapis:mainfrom
tritone:write-progress

Conversation

@tritone
Copy link
Copy Markdown
Contributor

@tritone tritone commented May 2, 2023

Fixes #7839

@tritone tritone requested review from a team May 2, 2023 19:35
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels May 2, 2023
Copy link
Copy Markdown
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just note that this fixes #7839 not #7798

@tritone
Copy link
Copy Markdown
Contributor Author

tritone commented May 3, 2023

Looks good, just note that this fixes #7839 not #7798

Whoops, good catch

@tritone tritone enabled auto-merge (squash) May 3, 2023 13:27
@tritone tritone merged commit aa8810d into googleapis:main May 3, 2023
@tritone tritone deleted the write-progress branch May 3, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage: Writer.ProgressFunc is always called at least once [GRPC]

2 participants