Skip to content

fix(internal/gapicgen): disable rest for non-rest APIs#7157

Merged
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
noahdietz:regapic-break
Dec 12, 2022
Merged

fix(internal/gapicgen): disable rest for non-rest APIs#7157
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
noahdietz:regapic-break

Conversation

@noahdietz
Copy link
Copy Markdown
Contributor

fix(osconfig/agentendpoint/v1beta1): disable REST transport generation
fix(mediatranslation/v1beta1): disable REST transport generation
chore(internal/gapicgen): update microgenerator to v0.33.5

As a result of updating the generator, when rest is a selected transport for a package, proto services lacking a REST-enabled method will not get a REST client type generated. This will break videointelligence/v1p3beta1 as a result. The aforementioned fixes are also breaking changes for those packages, but being in beta it is allowable.

@noahdietz noahdietz requested a review from a team December 12, 2022 17:35
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 12, 2022
@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Dec 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit ab332ce into googleapis:main Dec 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants