Skip to content

feat(pubsublite): create/update export subscriptions#6885

Merged
tmdiep merged 10 commits intogoogleapis:mainfrom
tmdiep:export_subscriptions
Dec 10, 2022
Merged

feat(pubsublite): create/update export subscriptions#6885
tmdiep merged 10 commits intogoogleapis:mainfrom
tmdiep:export_subscriptions

Conversation

@tmdiep
Copy link
Copy Markdown
Contributor

@tmdiep tmdiep commented Oct 18, 2022 •
edited
Loading

  • Added support for creating and updating export subscriptions, which write messages to a configured destination, for example a Pub/Sub topic. More destination types may be supported in the future.
  • Added support for creating subscriptions initialized to a target location within the message backlog. A seek is performed for publish and event timestamps.

@tmdiep tmdiep requested review from a team October 18, 2022 12:55
@tmdiep tmdiep requested a review from shollyman as a code owner October 18, 2022 12:55
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsublite Issues related to the Pub/Sub Lite API. labels Oct 18, 2022
@tmdiep tmdiep requested a review from codyoss October 18, 2022 12:55
@tmdiep
Copy link
Copy Markdown
Contributor Author

tmdiep commented Oct 18, 2022

@codyoss Can you please review the API surface changes in pubsublite/config.go and pubsublite/admin.go. Thanks!

@tmdiep tmdiep added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 19, 2022
codyoss
codyoss reviewed Oct 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments on the surface -- don't consider any of them blocking.

pubsublite/config.go

// ExportDestinationConfig is the configuration for exporting to a destination.
// Implemented by *PubSubConfig.
type ExportDestinationConfig interface {
Copy link
Copy Markdown
Member

@codyoss codyoss Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many of these do you anticipate? Could this just be a config struct instead of having the extra indirection?

Copy link
Copy Markdown
Contributor Author

@tmdiep tmdiep Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't predict how many, but there may be several in the future, hence the oneof-like representation.

@tmdiep tmdiep requested a review from codyoss October 25, 2022 05:56
@tmdiep tmdiep mentioned this pull request Oct 28, 2022
Merged
@tmdiep tmdiep requested a review from hongalex November 7, 2022 20:12
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Nov 18, 2022
@tmdiep tmdiep removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 9, 2022
@tmdiep tmdiep added the automerge Merge the pull request once unit tests and other checks pass. label Dec 10, 2022
@tmdiep tmdiep merged commit 5fa8555 into googleapis:main Dec 10, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 10, 2022
@tmdiep tmdiep deleted the export_subscriptions branch December 10, 2022 01:13
@release-please release-please bot mentioned this pull request Dec 10, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 12, 2022
@release-please
chore(main): release pubsublite 1.6.0 (#7129)
dc89409 
🤖 I have created a release *beep* *boop*
---


## [1.6.0](https://togithub.com/googleapis/google-cloud-go/compare/pubsublite/v1.5.0...pubsublite/v1.6.0) (2022-12-10)


### Features

* **pubsublite:** Create/update export subscriptions ([#6885](https://togithub.com/googleapis/google-cloud-go/issues/6885)) ([5fa8555](https://togithub.com/googleapis/google-cloud-go/commit/5fa855545502ab01775d19cc7b42810beefd1d5f))
* **pubsublite:** rewrite signatures and type in terms of new location ([620e6d8](https://togithub.com/googleapis/google-cloud-go/commit/620e6d828ad8641663ae351bfccfe46281e817ad))
* **pubsublite:** Unload idle partition publishers ([#7105](https://togithub.com/googleapis/google-cloud-go/issues/7105)) ([176f533](https://togithub.com/googleapis/google-cloud-go/commit/176f5331ff02dd9ae4eb706f299b31c903689298))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongalex hongalex hongalex approved these changes

@shollyman shollyman Awaiting requested review from shollyman

@codyoss codyoss Awaiting requested review from codyoss

Assignees

No one assigned

Labels

api: pubsublite Issues related to the Pub/Sub Lite API. size: l Pull request size is large. stale: old Pull request is old and needs attention.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmdiep @codyoss @hongalex