spanner: skip flaky TestIntegration_DbRemovalRecovery#14607
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request skips the TestIntegration_DbRemovalRecovery integration test in spanner/integration_test.go due to flakiness. The reviewer pointed out that placing t.Skip before t.Parallel() makes the latter unreachable and is non-idiomatic in Go, suggesting that t.Parallel() should remain the first statement.
|
|
||
| // Test client recovery on database recreation. | ||
| func TestIntegration_DbRemovalRecovery(t *testing.T) { | ||
| t.Skip("Flaky test, skipping for now (b/514205001)") |
Contributor
There was a problem hiding this comment.
The t.Skip call terminates the test execution immediately, making the subsequent t.Parallel() call and other setup code unreachable. This is generally non-idiomatic in Go and may be flagged by static analysis tools like go vet. It is recommended to place t.Parallel() as the first statement in the test function, followed by the t.Skip call.
Fixes b/514205001
d8ff8b2 to
95bd562
Compare
rahul2393
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/514205001