fix(storage): add retry logic for "http2: client connection lost"#14385
Conversation
Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request updates the ShouldRetry function to include "http2: client connection lost" as a retryable error and adds corresponding test cases for both direct and wrapped errors. The review feedback suggests making the new error string check nil-safe to prevent potential panics and adding a test case to verify that nil errors are handled gracefully.
Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
This adds
http2: client connection lostto the list of retriable errors. This matches similar retry logic added in bigquery. Tests have been updated to check for this new retry case, including wrapped errors.PR created automatically by Jules for task 5101149101639042241 started by @cpriti-os