chore: format repo metadata#14262
Conversation
There was a problem hiding this comment.
Code Review
This pull request standardizes the formatting of .repo-metadata.json files by removing trailing newlines. However, the reviewer noted that removing trailing newlines can cause compatibility issues with POSIX standards and common command-line tools. It is suggested to revert this change unless it is a strict requirement for an upcoming librarian Go migration.
| "language": "go", | ||
| "library_type": "GAPIC_AUTO", | ||
| "release_level": "stable" | ||
| } No newline at end of file |
There was a problem hiding this comment.
While the formatting is now consistent across the repository, removing the final newline from files is generally not recommended. It deviates from POSIX standards for text files and can cause issues with common command-line tools like cat, wc, and git.
Unless the upcoming 'librarian Go migration' strictly requires files without a trailing newline, I'd suggest removing the perl -i -pe 'chomp if eof' {} + step from your script to maintain better compatibility with standard text file conventions.
Format repo metadata, prepare for librarian Go migration.
The change is made through the following commands: