Skip to content

fix(internal/librariangen): get README title from service config yaml#12676

Merged
quartzmo merged 6 commits intogoogleapis:mainfrom
quartzmo:librariangen-librarian
Aug 8, 2025
Merged

fix(internal/librariangen): get README title from service config yaml#12676
quartzmo merged 6 commits intogoogleapis:mainfrom
quartzmo:librariangen-librarian

Conversation

@quartzmo
Copy link
Copy Markdown
Member

@quartzmo quartzmo commented Aug 8, 2025

* Update all testdata usages of ID value from generate-request.json
* Add testdata workflows_v1.yaml
* Replace incorrectly suppressed errors with returned errors
* Remove unneeded gofmt from integration test scripts
* Move goimports call to after version file creation in postprocess
* Get module import path from first API, not last
* Remove unused code from Generate
* Add support for GOOGLE_SDK_GO_LOGGING_LEVEL=debug
* Lower most log statements to debug
* Add librariangen prefix to all log statements
* Add librariangen prefix to all error messages

* Update all testdata usages of ID value from generate-request.json
* Add testdata workflows_v1.yaml
* Replace incorrectly suppressed errors with returned errors
* Remove unneeded gofmt from integration test scripts
* Move goimports call to after version file creation in postprocess
* Get module import path from first API, not last
* Remove unused code from Generate
* Add support for GOOGLE_SDK_GO_LOGGING_LEVEL=debug
@quartzmo quartzmo requested a review from a team August 8, 2025 16:55
Comment thread internal/librariangen/generate/generator.go Outdated
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit

@quartzmo quartzmo merged commit b3b8f70 into googleapis:main Aug 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants