feat(storage/transfermanager): add DownloadDirectory #10430
Merged
Merged
Conversation
Prototype. Follow-up PRs: - Cleanup on failure - Skipifexists + option to fail if exists? - strip prefix ? (strip prefix on local files) - if empty object, create a directory instead ? - possibly more integration tests
tritone
reviewed
Jun 26, 2024
tritone
left a comment
Contributor
There was a problem hiding this comment.
A few minor things; generally looks good
tritone
reviewed
Jun 28, 2024
tritone
approved these changes
Jul 3, 2024
tritone
left a comment
Contributor
There was a problem hiding this comment.
One more minor suggestion, otherwise looks good.
| Callback func([]DownloadOutput) | ||
|
|
||
| // OnObjectDownload will run after every finished object download. | ||
| // It can only be set if the Downloader has the [WithCallbacks] option set. |
Contributor
There was a problem hiding this comment.
I think we could probably loosen this requirement? A user could want to run in sync mode and still use this to track/log progress.
tritone
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mvp
Follow-up PRs: