test(pubsub): make error checking of receive less brittle#10165
Merged
hongalex merged 5 commits intogoogleapis:mainfrom May 14, 2024
Merged
test(pubsub): make error checking of receive less brittle#10165hongalex merged 5 commits intogoogleapis:mainfrom
hongalex merged 5 commits intogoogleapis:mainfrom
Conversation
shollyman
reviewed
May 14, 2024
Contributor
shollyman
left a comment
There was a problem hiding this comment.
Generally, these all seem like a good case for a swap to errors.Is(err, context.Cancelled) rather than a direct equality check.
shollyman
approved these changes
May 14, 2024
Contributor
shollyman
left a comment
There was a problem hiding this comment.
approving based on discussed refactoring
…le-cloud-go into test-pubsub-receive-cancel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Receivecan occasionally returncontext.Canceled. This makes tests that callReceiveless brittle by checking explicitly forcanceled. This also replaces checks of thecodes.Canceledstatus code.