This repository was archived by the owner on Nov 20, 2025. It is now read-only.
fix: pin nock and typescript dependencies to fix window.crypto.subtle.verify signature argument type#2106
Merged
miguelvelezsa merged 1 commit intomainfrom Aug 1, 2025
Conversation
….verify signature argument type
sofisl
approved these changes
Aug 1, 2025
Contributor
|
Linking for reference: microsoft/TypeScript#14116 We talked about it on chat, but going forward it looks like we can lock to minver safely ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a new TS version, we are getting an error in crypto file [1].
Also test are timing out due to a new version in nock.
Set specific versions for both dependencies as short term solution, until we implement the real fix.
[1] src/crypto/browser/crypto.ts:94:7 - error TS2345: Argument of type 'Uint8Array' is not assignable to parameter of type 'BufferSource'.
Type 'Uint8Array' is not assignable to type 'ArrayBufferView'.
Types of property 'buffer' are incompatible.
Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'.
Types of property '[Symbol.toStringTag]' are incompatible.
Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'.
94 signatureArray,
~~~~~~~~~~~~~~
src/crypto/node/crypto.ts:90:3 - error TS2322: Type 'ArrayBuffer | SharedArrayBuffer' is not assignable to type 'ArrayBuffer'.
Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'.
Types of property '[Symbol.toStringTag]' are incompatible.
Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'.
90 return buffer.buffer.slice(