This repository was archived by the owner on Nov 20, 2025. It is now read-only.
build: Fixing tests that use reqheaders improperly#1589
Merged
aeitzman merged 3 commits intogoogleapis:mainfrom Jul 11, 2023
Merged
build: Fixing tests that use reqheaders improperly#1589aeitzman merged 3 commits intogoogleapis:mainfrom
aeitzman merged 3 commits intogoogleapis:mainfrom
Conversation
danielbankhead
approved these changes
Jul 11, 2023
This was referenced Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing tests that are using reqheaders for nock improperly. Quite a few of our tests, especially for externalaccount clients, use reqheaders on the nock interceptors instead of the scope. Nock does not actually check for the request headers if passed to an interceptor, so this changes all of those uses. Also adds nock.cleanAll() for the test files that do not have it already in aftereach().