feat(google-api-go-generator): add universe domain support#2335
Merged
quartzmo merged 5 commits intogoogleapis:mainfrom Jan 9, 2024
Merged
feat(google-api-go-generator): add universe domain support#2335quartzmo merged 5 commits intogoogleapis:mainfrom
quartzmo merged 5 commits intogoogleapis:mainfrom
Conversation
shollyman
reviewed
Jan 8, 2024
codyoss
approved these changes
Jan 9, 2024
Member
codyoss
left a comment
There was a problem hiding this comment.
LGTM. Is mTLS in scope of universe stuff? Or is that later?
Member
Author
|
@codyoss My understanding was that the default mTLS endpoint should be left as-is for now, but I'll double-check. |
Member
Author
|
@codyoss: Per @viacheslav-rostovtsev, "currently configuring MTLS with universe domains should return an error", so the |
shollyman
approved these changes
Jan 9, 2024
Contributor
shollyman
left a comment
There was a problem hiding this comment.
Thanks for getting this together!
This was referenced Jan 17, 2024
stanhu
added a commit
to stanhu/go-cloud
that referenced
this pull request
Jan 28, 2026
In googleapis/google-api-go-client#2335, Google added support for configuring a universe domain to support different Google Cloud domains. This commit adds a `universe_domain` query parameter to retrieve credentials and access Google Cloud Storage with a different domain.
gitlab-runner-bot
pushed a commit
to gitlabhq/gitlab-runner
that referenced
this pull request
Feb 3, 2026
A customer needs support for Google Cloud Dedicated: https://cloud.google.com/sovereign-cloud?hl=en This supports the `universe_domain` setting added in googleapis/google-api-go-client#2335. Relates to https://gitlab.com/gitlab-org/gitlab/-/work_items/581881 Changelog: added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.